feat: add non-retryable exception pattern matching#212
Draft
hexinw-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
Draft
feat: add non-retryable exception pattern matching#212hexinw-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
hexinw-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
hexinw-nvidia
requested review from
anjalibshah,
apaithankar,
namitdhameja,
rhewett-nv and
sbak5
Add --ft-non-retryable-exception-file to mark nodes unhealthy when workers fail with specific exception patterns (e.g., config errors). This prevents retrying on errors that won't be fixed by retrying. Implementation: - Workers write full tracebacks via sys.excepthook to error files - Launcher checks error files against configured patterns on worker failure - Nodes with matching exceptions increment unhealthy_count and exit - Rendezvous uses unhealthy_count to decide if job can continue Example: Configure patterns like "insufficient shared memory (shm)" to stop retry on configuration error.
hexinw-nvidia
force-pushed
the
stop_retry
branch
from
3107ef8 to
c6dd9d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --ft-non-retryable-exception-file to mark nodes unhealthy when workers fail with specific exception patterns (e.g., config errors). This prevents retrying on errors that won't be fixed by retrying.
Implementation:
Example: Configure patterns like "insufficient shared memory (shm)" to stop retry on configuration error.