fix: make multistorageclient import conditional in async_writer example#265
Merged
hexinw-nvidia merged 1 commit intoNVIDIA:mainfrom Feb 19, 2026
Merged
Conversation
Contributor
Greptile SummaryWrapped the
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: f063c89 |
1d75310 to
5243ba6
Compare
hexinw-nvidia
approved these changes
Feb 18, 2026
rhewett-nv
approved these changes
Feb 18, 2026
c927634 to
df670db
Compare
Contributor
|
@ShreyaGupta08 Please sign your commit. Thanks. |
The async_writer.py example unconditionally imports multistorageclient, which causes an immediate ImportError for users who don't have it installed — even when they're not using the --enable_msc flag. This change makes the import conditional (try/except) and adds an explicit guard in main() that raises a clear error message only when --enable_msc is actually requested without the package installed.
df670db to
f063c89
Compare
Contributor
Author
|
@hexinw-nvidia all the tests pass, can you merge the PR? I don't get an option to merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async_writer.py example unconditionally imports multistorageclient, which causes an immediate ImportError for users who don't have it installed — even when they're not using the --enable_msc flag.
This change makes the import conditional (try/except) and adds an explicit guard in main() that raises a clear error message only when --enable_msc is actually requested without the package installed.