Fix map zoom out issue on Android

[kevinherdez]

#1042

This fixes an issue that we've had on Android where the map in the observation location field was zoomed out on Android. I'm approaching this fix as more of a stopgap solution since, hopefully, we will be changing map packages soon.

This also makes 2 updates to the modal that I decided to go ahead and fix while making changes here.

• Move the close button to the left and the save button to the right to be aligned with the other modals in the app
• Change how the location saving work.
  • Before: hitting X clears out the location, map taps automatically save the location, the checkmark just closes the modal
  • Now: Hitting the X closes the modal, hitting the checkmark saves the location, map taps just update the value

This fix is based off this issue that was reported on react-native-maps. While we don't have the version that's impacted talked about here, the issue seems the same so I changed how the map is mounted so that it's only mounted and shown when the modal is displayed instead of behind the scenes like it was.
react-native-maps/react-native-maps#5563

Caveats:

• On my device there's a slight flicker when showing the modal because the map is loading as the modal is being shown. I think
• Every once and awhile the map shows zoomed out still. On my device if I close and reopen the modal, it fixes the issue

Recording of testing from Pixel 6a:
https://github.com/user-attachments/assets/b4015dce-ca34-413a-8a5b-f93edac907cb
What's shown:

• Initial map opening
• Tapping and saving location
• Changing location but hitting the X showing it's not saved and not cleared out anymore
• Updating the location and hitting save
• Showing the change was saved

[stevekuznetsov]

Seems reasonable enough

[yuliadub]

Change how the location saving work.

• Before: hitting X clears out the location, map taps automatically save the location, the checkmark just closes the modal
• Now: Hitting the X closes the modal, hitting the checkmark saves the location, map taps just update the value

do we need to worry about users being confused by this change? I know we have wanted to do some sort of change here a while ago but stopped to not cause user confusion 😄 @rustynwac maybe that is a you question. I am convinced people will figure it out likely, but if there is feedback you will be the one to suffer from it.

p.s. I totally know the experience today is already confusing but at least it has been consistently confusing for a while now

[kevinherdez]

Change how the location saving work.

• Before: hitting X clears out the location, map taps automatically save the location, the checkmark just closes the modal
• Now: Hitting the X closes the modal, hitting the checkmark saves the location, map taps just update the value

do we need to worry about users being confused by this change? I know we have wanted to do some sort of change here a while ago but stopped to not cause user confusion 😄 @rustynwac maybe that is a you question. I am convinced people will figure it out likely, but if there is feedback you will be the one to suffer from it.

p.s. I totally know the experience today is already confusing but at least it has been consistently confusing for a while now

I might be too close to the problem, but I was so confused the first time I used the modal that hitting the X cleared out the field. Since it's a required field I don't really understand the need to clear out the field when the user can just pull up the modal and update the location. However, if there's past feedback that we've gotten saying that this is what users want I can change it back.

[rustynwac]

gotten

I don't find the current one to be too confusing though I see what you're saying. I think less change is probably better where possible.

[kevinherdez]

gotten

I don't find the current one to be too confusing though I see what you're saying. I think less change is probably better where possible.

Okay, I'll change the functionality of the X button back to what it was, but I'll leave the updated button position. It just makes it consistent with the other modals we have in the app