package.json: bump to Expo 53.0.20 #955

yuliadub · 2025-08-11T21:22:53Z

Updating expo and dependencies. Ran into a random error with @types/md5 module not being found but after a clean install of all packages everything booted as expected.

Did the upgrade following expo directions here: https://docs.expo.dev/workflow/upgrading-expo-sdk-walkthrough/

had to up version of node to support the upgrades in GAH setup.
had to update some eslint ignores
had to resolve some new typescript complaints

yuliadub · 2025-08-11T21:41:15Z

looks like CI is unhappy, looking into it

stevekuznetsov · 2025-08-11T22:41:47Z

If you can, don't blow away node_modules and re-install, it will change so many dependencies it's very hard to guarantee that we didn't regress things. In the past we've introduced a dozen bugs that way :|

yuliadub · 2025-08-12T17:30:01Z

If you can, don't blow away node_modules and re-install, it will change so many dependencies it's very hard to guarantee that we didn't regress things. In the past we've introduced a dozen bugs that way :|

good to know! I will try again without blowing it away

yuliadub · 2025-08-14T04:23:29Z

If you can, don't blow away node_modules and re-install, it will change so many dependencies it's very hard to guarantee that we didn't regress things. In the past we've introduced a dozen bugs that way :|

good to know! I will try again without blowing it away

@stevekuznetsov ok, not blowing away yarn.lock but the changes still look massive. Wonder if that is because I am updating a lot of packages? Seems like that is good to do since we are behind on a few. There are at least 2 packages I found where the newer version will require some code refactor, I will make issue for those but right now upped them to the version that still works with code as is.

still need to fix yarn test

stevekuznetsov · 2025-08-14T12:47:04Z

The 16k LoC diff is from running the Expo upgrade? Yikes

yuliadub · 2025-08-14T17:25:52Z

The 16k LoC diff is from running the Expo upgrade? Yikes

yup agreed 😨

npx expo install expo@latest npx expo install --fix

yuliadub · 2025-08-16T04:38:07Z

ok. to follow up on this - something weird is happening with one of my Windows machines that is running WSL. When I went to run yarn install on my different windows machine, the changes in yarn.lock look a lot more reasonable and what we would expect. Still need to figure out why the tests are failing but getting close!

yuliadub · 2025-08-20T05:29:50Z

expo /preview

github-actions · 2025-08-20T05:33:31Z

Preview in Expo Go

iOS	Android

`exp://u.expo.dev/update/969c1fbb-710a-408d-8af5-33fda02ed546`	`exp://u.expo.dev/update/8f95a485-f9e4-4dd8-acd5-1ecdfa2bf6dd`

github-actions · 2025-08-20T05:33:32Z

expo_preview: succeeded ✅
https://github.com/NWACus/avy/actions/runs/17089453536

yuliadub · 2025-08-20T05:39:15Z

alright, got all this resolved but now if you look at the expo go preview - when clicking into a map zone, looks like the app crashes. Gonna keep debugging whats up (the map doesnt load on the emulator on my machine so gotta get creative 😄 )

kevinherdez · 2025-08-21T08:25:53Z

alright, got all this resolved but now if you look at the expo go preview - when clicking into a map zone, looks like the app crashes. Gonna keep debugging whats up (the map doesnt load on the emulator on my machine so gotta get creative 😄 )

Was that testing on iPhone or Android? I tested on iPhone real quick and I hit weird issues where random zones would disappear when clicking on other ones. I'll see if I can't get them to load locally to help investigate.

stevekuznetsov · 2025-08-21T17:31:02Z

The "new architecture" breaks the map entirely - IIRC in Expo Go, they always run the new architecture, regardless of whether your project's config has it turned on or not. So, I think that's expected behavior and won't happen in the preview app.

stevekuznetsov · 2025-08-21T17:32:23Z

xref: 8f4cce2

yuliadub · 2025-08-22T05:24:41Z

The "new architecture" breaks the map entirely - IIRC in Expo Go, they always run the new architecture, regardless of whether your project's config has it turned on or not. So, I think that's expected behavior and won't happen in the preview app.

well its actually interesting - on an android emulator inside expo go no maps loads for me period. When running expo preview here from the PR, with the app also opening in expo go, the map does load and it crashes when I go to a specific zone, so I do think this is a real crash (plus Kevin did confirm that he is seeing this on iOS as well)

thanks to @kevinherdez, the map now works and the obs submit button as well (another thing that was broken by the updates) - right now something is up with the header in obs list and obs details. Filter is missing and on obs detailed page the top section is hidden under the header. my emulator refused to load the app for some reason so I didnt have the chance to dig further. If you have a chance to look and find anything, here for all the help to get this finished :)

yuliadub · 2025-08-22T05:24:51Z

expo /preview

github-actions · 2025-08-22T05:28:28Z

expo_preview: succeeded ✅
https://github.com/NWACus/avy/actions/runs/17146891749

yuliadub · 2025-08-22T06:17:25Z

components/content/NavigationHeader.tsx

      firstOpen = true;
      // set back to not be null since we want a shared obs to have a back button
-      back = {title: 'Observations'};
+      back = {title: 'Observations', href: undefined};


need to look into what href should be

stevekuznetsov · 2025-08-22T12:15:19Z

Sure, of course chase real breaks, but keep that in mind since you will get weird behavior with the zones, etc, and there's nothing to be done.

kevinherdez · 2025-08-22T14:47:12Z

The "new architecture" breaks the map entirely - IIRC in Expo Go, they always run the new architecture, regardless of whether your project's config has it turned on or not. So, I think that's expected behavior and won't happen in the preview app.

Ah yeah I had forgot that you mentioned that awhile ago. Good callout

kevinherdez · 2025-08-22T14:55:40Z

The "new architecture" breaks the map entirely - IIRC in Expo Go, they always run the new architecture, regardless of whether your project's config has it turned on or not. So, I think that's expected behavior and won't happen in the preview app.

well its actually interesting - on an android emulator inside expo go no maps loads for me period. When running expo preview here from the PR, with the app also opening in expo go, the map does load and it crashes when I go to a specific zone, so I do think this is a real crash (plus Kevin did confirm that he is seeing this on iOS as well)

thanks to @kevinherdez, the map now works and the obs submit button as well (another thing that was broken by the updates) - right now something is up with the header in obs list and obs details. Filter is missing and on obs detailed page the top section is hidden under the header. my emulator refused to load the app for some reason so I didnt have the chance to dig further. If you have a chance to look and find anything, here for all the help to get this finished :)

I dug into this, and it seems like the behavior with the custom header and using absolute positioning for the views that are being shown changed. What's going on is that all of the views that use NavigationHeader and have a style set to absolute are being hidden by the header because they're no longer respecting the space being taken up by it.

Here's what I did to fix:

ObservationsScreen.tsx: remove line 69 that has ...StyleSheet.absoluteFillObject,
WeatherScreen.tsx: lines 38, 51, 62 replace style={{...StyleSheet.absoluteFillObject}} with flex={1}

A better fix for the WeatherScreen.tsx would be to create a custom StyleSheet like in ObservationsScreen to only have to change this code in one area, but hopefully are the minimum changes needed to get this fixed.

yuliadub · 2025-08-23T03:45:26Z

flex={1}

sweet, that did it. agree that we can refactor in the future! I think I wanna merge this PR first (#904) and then merge this. did a quick look around and didnt find any other issues, but we will also run a deeper test on the preview app once we get a preview build!

This reverts commit 41ce487.

…ive architecture (#971) * Revert "A few more udpates to support expo 53 SDK (#967)" This reverts commit 805d059. * Revert "package.json: bump to Expo 53.0.20 (#955)" This reverts commit 41ce487.

* update expo to 53.0.20. ensure yarn.lock is not being blown away * eslint came up with more errors somehow * fix tests * making expo doctor a bit happier * more package updates to help fix crashes * fix error created by previous package update * fix cutoff headers

…ive architecture (#971) * Revert "A few more udpates to support expo 53 SDK (#967)" This reverts commit 805d059. * Revert "package.json: bump to Expo 53.0.20 (#955)" This reverts commit 41ce487.

yuliadub force-pushed the updateExpo branch 2 times, most recently from 9b71b16 to f8561b0 Compare August 14, 2025 04:20

update expo to 53.0.20. ensure yarn.lock is not being blown away

d303029

yuliadub force-pushed the updateExpo branch from 686bcc9 to d303029 Compare August 16, 2025 03:31

eslint came up with more errors somehow

d49ca3c

fix tests

617525b

yuliadub force-pushed the updateExpo branch from a33fae8 to 617525b Compare August 20, 2025 05:18

making expo doctor a bit happier

a36326d

yuliadub added 2 commits August 21, 2025 22:11

more package updates to help fix crashes

a1d35d7

fix error created by previous package update

5c08c47

yuliadub commented Aug 22, 2025

View reviewed changes

fix cutoff headers

16a4b57

yuliadub added this pull request to the merge queue Aug 29, 2025

Merged via the queue into main with commit 41ce487 Aug 29, 2025
4 of 5 checks passed

yuliadub deleted the updateExpo branch August 29, 2025 04:21

yuliadub added a commit that referenced this pull request Oct 18, 2025

Revert "package.json: bump to Expo 53.0.20 (#955)"

40c8f66

This reverts commit 41ce487.

package.json: bump to Expo 53.0.20 #955

package.json: bump to Expo 53.0.20 #955

Uh oh!

Conversation

yuliadub commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuliadub commented Aug 11, 2025

Uh oh!

stevekuznetsov commented Aug 11, 2025

Uh oh!

yuliadub commented Aug 12, 2025

Uh oh!

yuliadub commented Aug 14, 2025

Uh oh!

stevekuznetsov commented Aug 14, 2025

Uh oh!

yuliadub commented Aug 14, 2025

Uh oh!

yuliadub commented Aug 16, 2025

Uh oh!

yuliadub commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview in Expo Go

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

yuliadub commented Aug 20, 2025

Uh oh!

kevinherdez commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevekuznetsov commented Aug 21, 2025

Uh oh!

stevekuznetsov commented Aug 21, 2025

Uh oh!

yuliadub commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuliadub commented Aug 22, 2025

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

yuliadub Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

stevekuznetsov commented Aug 22, 2025

Uh oh!

kevinherdez commented Aug 22, 2025

Uh oh!

kevinherdez commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuliadub commented Aug 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yuliadub commented Aug 11, 2025 •

edited

Loading

github-actions bot commented Aug 20, 2025 •

edited

Loading

kevinherdez commented Aug 21, 2025 •

edited

Loading

yuliadub commented Aug 22, 2025 •

edited

Loading

kevinherdez commented Aug 22, 2025 •

edited

Loading