Sort International (INTL) state option to bottom of providers embed list #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, states were sorted alphabetically which placed INTL between IL (Illinois) and IN (Indiana). This change uses a custom sort comparator to ensure INTL always appears last while maintaining alphabetical order for all other states. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Preview deployment: https://international-to-bottom.preview.avy-fx.org |
rchlfryn
approved these changes
Jan 16, 2026
Collaborator
rchlfryn
left a comment
rchlfryn
left a comment
There was a problem hiding this comment.
LG
Bonus points: Can you update my mistake https://github.com/NWACus/web/blob/main/src/utilities/queries/getCoursesStates.ts#L35-L39 to use the sort function as well? At first I thought findByIndex was more efficient but I was wrong since there are multiple array mutations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, states were sorted alphabetically which placed INTL between IL (Illinois) and IN (Indiana). This change uses a custom sort comparator to ensure INTL always appears last while maintaining alphabetical order for all other states.
Screenshots / Demo video
Check out: https://international-to-bottom.preview.avy-fx.org/embeds/providers