-
Notifications
You must be signed in to change notification settings - Fork 3
Ar migrate storage builds drafts #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexrichey
wants to merge
12
commits into
main
Choose a base branch
from
ar-migrate-storage-builds-drafts-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ccfd61 to
232ee0d
Compare
e6d700f to
5d2328a
Compare
34f6ef9 to
6180d94
Compare
This was taking a long time. I think there's absolutely utility in running a scraper against BYTES every week or so, but this is just too much
Having to re-populate my .env after an *unfortunate* incident (see two commits ahead) prompted this. It's a little out of date.
This was... maybe the worst two lines of code I have every written. If you used this connector to attempt to download a file to, say, your data-engineering/ directory, it would wipe the directory
6180d94 to
8258bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implements the Connectors for builds, drafts, published and gis, but doesn't swap them out just yet. You can read commit-by-commit for localized/grouped changes (e.g. just changes to builds functionality) as well as explanations for the smaller changes in the commit messages. (There's some 🌶️ content in the commit bodies)
Anyhow, the logic in
published.pyis basically distributed into files in a few different locations:There will be some continuing commits where we implement this:
@fvankrieken @damonmcc Here's where I could use some input:
Consider a command like publishing a draft. This command needs to
Ideally this code would live in a module a little bit "above" artifacts/drafts and artifacts/published, almost similar to how lifecycle/scripts lives "above" the various lifecycle stages.
So I'd love it if you could take a look at the files under dcpy/lifecycle/builds/artifacts/*, and consider these "glue" functions like promote and publish. In the CLI they fit really nicely under namespaced commands like
dcpy lc builds artifacts drafts publish -p nypl_libraries -v 24v1 -dn 2 -ipwhich make sense, because we
publishingis an action that we take on a draft. However, where this glue code should live... I could use some input.