Extend duration of 'remember me' cookie #231
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, users would have to sign in every 2 weeks (unless they configure their web browser to restore session cookies on restart). Increase the duration to 1 month, and also enable the `extend_remember_period` feature so that the cookie will be automatically renewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, creating this so we won't forget. It came up in #162.
The 1 month is mostly arbitrary, happy to change it. (I thought 1 month is long enough for regular users, and that if someone has been away >1 month then it's fair to sign them out.)
I'm not completely certain how Devise behaves; my commit message might be inaccurate.