Skip to content

Use correct group name for isolate/isolock #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tom93 merged 4 commits into from
Jan 1, 2024
Merged

Use correct group name for isolate/isolock #236

tom93 merged 4 commits into from
Jan 1, 2024

Conversation

@tom93
Copy link
Contributor

@tom93 tom93 commented Jan 1, 2024 •
edited
Loading

Previously the scripts assumed that the group name is the same as the username, but that's not necessarily the case.

This came up in #223.

Merge using "rebase".

tom93 added 4 commits January 2, 2024 01:35
@tom93
Reword explanation of config var APP_USER (#236)
d6a7a37 
Currently, this configuration variable doesn't *cause* the app to run
as that username. We just ask for it so that we can set the correct
ownership on some files.
@tom93
Add config var APP_GROUP (#236)
cfec596 
Previously the scripts assumed that the group name is the same as the
username, but that's not necessarily the case.
@tom93
Use APP_GROUP for group of isolate/isolock (#236)
e33ed4e 
Previously the scripts assumed that the group name is the same as the
username, but that's not necessarily the case.
@tom93
Don't set isolock to be setgid (#236)
6b6781d 
It only needs to be setuid, like isolate.
@tom93 tom93 changed the title Set correct group name for isolate/isolock Use correct group name for isolate/isolock Jan 1, 2024
@tom93 tom93 merged commit a82e461 into master Jan 1, 2024
@tom93 tom93 deleted the isolate-app-group branch January 1, 2024 13:46
tom93 added a commit that referenced this pull request Jan 1, 2024
@tom93
Reword explanation of config var APP_USER (#236)
7ba1011 
Currently, this configuration variable doesn't *cause* the app to run
as that username. We just ask for it so that we can set the correct
ownership on some files.
tom93 added a commit that referenced this pull request Jan 1, 2024
@tom93
Add config var APP_GROUP (#236)
c6f417d 
Previously the scripts assumed that the group name is the same as the
username, but that's not necessarily the case.
tom93 added a commit that referenced this pull request Jan 1, 2024
@tom93
Use APP_GROUP for group of isolate/isolock (#236)
a85f499 
Previously the scripts assumed that the group name is the same as the
username, but that's not necessarily the case.
@tom93 tom93 mentioned this pull request Jan 1, 2024
Closed
@tom93
Copy link
Contributor Author

tom93 commented Jan 2, 2024 •
edited
Loading

Deployed new permissions of isolock manually.
Manually added APP_GROUP to script/install.cfg.
While doing that, I noticed APP_USER was set to "nztrain", which is odd because the web server currently runs as the "deploy" user (I couldn't find where we set that user, so I assume it's due to auto detection). I changed it to "deploy" (though it doesn't really matter because APP_USER is basically unused).
I'll open an issue to decide if we want to make the app run as the "nztrain" user. (#238)
I also noticed that isolock's group was set to "nztrain" (update from chat: turns out that was recent and unintentional). I changed that to "deploy" for now to avoid breakage.

@tom93 tom93 mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Holmes98 Holmes98 Holmes98 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tom93 @Holmes98