Skip to content

Conversation

@ChristopherCaradonna
Copy link
Contributor

Pull request overview

Adds rupocop cleanup and some measure test fixes.

Pull Request Author

This pull request makes changes to (select all the apply):

  • Upgrade Measures

Pull Request Author Checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added or edited tests for measures that adequately cover anticipated cases
  • Added 'See ComStock License' language to first two lines of each code file
  • Run rubocop and ensure no ADDITIONAL errors or errors in functions / files edited
  • Updated measure .xml(s)
  • Ran 10k+ test run and checked failure rate to make sure no new errors were introduced

Pull Request Reviewer Checklist:

  • Perform a code review on GitHub
  • All changes have been implemented: data, methods, tests, documentation
  • Measure tests written and adequately cover anticipated cases
  • Check edited measure .xml files updated

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2025 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

kflemin and others added 30 commits August 27, 2025 13:35
* fix missing district emissions in postproc

- add district emissions columns, add to naming mixin, and list downselect option in log

* Update comstock_to_cbecs_comparison.py

Don't try to plot end use stacked bar comparisons unless there are at least 2 discrete values in the groupby column. For now, this means 2 different comstock runs. May edit later to accommodate CBECS.
Turn off equipment counts (HVAC and water heater)
eringold and others added 29 commits November 25, 2025 09:13
…_breakdown

Ccaradoj/sdr 2025 r4 fix other fuel breakdown
…_breakdown

add missing imports, remove duplicate propane and fuel oil columns
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…_plots

Ccaradon/sdr 2025 r4 fix timeseries plots
- add expand_path to load_model() to resolve relative path before attempting to load
- fix issue in upgrade_hvac_packaged_gshp with an extra space in fan_variable_volume_set_control_type
- correct Class name in tests for upgrade_hvac_replace_boiler_by_heatpump
updates from rubocop based on run with comstock config
Updates after running rubocop with comstock specific config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants