Fix: Flatten (N, 1) arrays to (N,) for NumPy/Ctypes updates #510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten matrix-shaped arrays to 1D arrays for
c_doublecastingThis PR is addressing the test failures cropping up in #509 caused by passing a (N, 1) NumPy array to a (N,)
c_doublearray. By reshaping the NumPy arrays to shape (N,) the issue is resolved.PR Checklist
RELEASE.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessaryRelated issues
N/A, this is a brand new issue blocking a PR.
Impacted areas of the software
hopp/simulation/technologies/pySSC_daotk/ssc_wrap.pyPySSC.data_set_array: reshapes the passed NumPy array from (N, 1) to (N).hopp/simulation/technologies/csp/pySSC_daotk/ssc_wrap.pyPySSC.data_set_array: reshapes the passed NumPy array from (N, 1) to (N).Additional supporting information
All test failures were due to this line of code in
hopp/simulation/technologies/pySSC_daotk/ssc_wrap.py::PySSC.data_set_arrayTest results, if applicable