Schema handling #202
Open
Schema handling #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLiNREL
reviewed
Jan 23, 2026
| "era5-quantiles": { | ||
| "source": "athena", | ||
| "schema": "quantile_yearly", | ||
| "period_type": { |
Collaborator
There was a problem hiding this comment.
the period_type is specific to schema, might want to consider move it as part of the schema constant
windwatts-ui/src/types/DataModel.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| export type DataModel = "wtk" | "era5" | "ensemble"; | |||
| export type DataModel = "wtk-timeseries" | "era5-quantiles" | "ensemble-quantiles"; | |||
windwatts-ui/src/utils/urlParams.ts
Outdated
|
|
||
| const dataModel = params.get("dataModel"); | ||
| if (dataModel === "era5" || dataModel === "wtk" || dataModel === "ensemble") { | ||
| if (dataModel === "era5-quantiles" || dataModel === "wtk-timeseries" || dataModel === "ensemble-quantiles" || dataModel === "era5-timeseries") { |
Collaborator
There was a problem hiding this comment.
maybe consider check infer from an valid DATA_MODELS array
export const DATA_MODELS = [
"wtk-timeseries",
"era5-quantiles",
"ensemble-quantiles",
] as const;
instead of explicitly checking each possible value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened a PR to work on schema handling will add more notes here