[FINNA-4205] Simplify SkosmosEnrichment and AuthEnrichment to use single service classes #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LuomaJuha
commented
Dec 8, 2025
LuomaJuha
commented
- Map all the keys in solrupdater to use same cache key to avoid saving multiple instances of enrichment service
- All enrichment logic is now located in single service instead of record specific services.
…perly to avoid multiple instances.
LuomaJuha
changed the title
EreMaijala
requested changes
Dec 15, 2025
Contributor
EreMaijala
left a comment
EreMaijala
left a comment
There was a problem hiding this comment.
Can we rid of ead3Fields and lidoFields and just put everything in defaultFields (that could be renamed to $fields)? It should be up to the record class to provide (or decide not to provide) the identifiers for each get..Ids call.
EreMaijala
requested changes
Dec 16, 2025
Contributor
EreMaijala
left a comment
EreMaijala
left a comment
There was a problem hiding this comment.
Muuten hyvä, mutta kun EnrichmentMapping-enumia ei voi käyttää enumina, koska se estäisi omien enrichmentien lisäämisen alajuoksulla, niin sen olemassaololle ei ole oikein hyvää perustetta.
EreMaijala
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.