Skip to content

Comments

Accessibility testing#9

Open
NatanimA wants to merge 5 commits intomasterfrom
Accessibility-Testing
Open

Accessibility testing#9
NatanimA wants to merge 5 commits intomasterfrom
Accessibility-Testing

Conversation

@NatanimA
Copy link
Owner

@NatanimA NatanimA commented Aug 30, 2022

  • Page titles - no issues found
  • Image text alternatives- no issues found
  • Text headings- no issues found
  • Color contrast - no issues found
  • Resize - no issues found
  • Interactions- no issues found
  • Moving content - no issues found
  • Multimedia - no issues found
  • Basic Structures of the page - no issues found

Copy link

@emmiiorji emmiiorji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NatanimA,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a pair programming project having commits from a single partner.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Copy link

@Reem-lab Reem-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team,👋🏻👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉🔥🔥💯💯

Highlights ✨✨

📌 No Linters error ✅
📌 Descriptive pull request✅
📌 Great working on the accessibilty✅
📌 Good commit messages ✅
📌 Professional README ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants