Skip to content

Conversation

@NathanNeurotic
Copy link
Owner

Motivation

  • Silence cppcheck missingIncludeSystem findings by explicitly suppressing them where angle-bracket includes are used.
  • Apply the suppression uniformly across headers and sources so static analysis results are consistent and actionable.
  • Keep code semantics and formatting unchanged while only inserting the required suppression comment lines.

Description

  • Inserted // cppcheck-suppress missingIncludeSystem immediately above every #include <...> line across affected files and preserved existing spacing and formatting.
  • Did not modify #include "..." lines or any other macros/whitespace besides the single-line suppressions.
  • Changes touch 23 files with a total of 134 inserted suppression lines to cover all system-style includes.
  • Verification ensures only the missingIncludeSystem id was used for suppression and comments are on their own lines directly above the includes.

Testing

  • Ran the insertion script (Python) to add suppressions and it completed without errors.
  • Executed a repo-wide verification script that scanned include/ and src/ and reported "All includes suppressed".
  • Performed automated spot-checks of include/debugprintf.h, src/dvdplayer.c, and include/main.h to confirm the comment sits immediately above the #include <...> lines.
  • Generated a diff summary showing 23 files changed, 134 insertions to confirm the scope of edits.

Codex Task

@codacy-production
Copy link

Codacy's Analysis Summary

0 new issue (≤ 0 issue)
0 new security issue
0 complexity
0 duplications

Review Pull Request in Codacy →

AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

@NathanNeurotic NathanNeurotic merged commit 0c711c3 into main Jan 8, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants