Project creation form#975
Open
alneberg wants to merge 90 commits intoNationalGenomicsInfrastructure:masterfrom
Open
Project creation form#975alneberg wants to merge 90 commits intoNationalGenomicsInfrastructure:masterfrom
alneberg wants to merge 90 commits intoNationalGenomicsInfrastructure:masterfrom
Conversation
…alidation is not triggered, dont't know why
Add suggestions on account name, autofill of project name
aanil
reviewed
Dec 10, 2025
Co-authored-by: Anandashankar Anil <aanil@users.noreply.github.com>
aanil
reviewed
Dec 10, 2025
aanil
reviewed
Dec 10, 2025
aanil
reviewed
Dec 10, 2025
ssjunnebo
approved these changes
Dec 12, 2025
Contributor
ssjunnebo
left a comment
ssjunnebo
left a comment
There was a problem hiding this comment.
LGTM! I've just left some very minor comments.
Also, in the "User account" field, the sorting of the suggestions that appear is reversed alphabetical. Also not that important, but possibly someone could be annoyed by it eventually 😄
Comment on lines
+59
to
+64
| # If the requested version is the only thing in active_forms, it's fine | ||
| if version_id not in active_forms: | ||
| return False | ||
| # If the requested version is not in active_forms, it's not fine | ||
| if len(active_forms) == 1: | ||
| return True |
Contributor
There was a problem hiding this comment.
Should the comments be the other way around?
| """Handler used to render the project creation page using the valid form.""" | ||
|
|
||
| def get(self): | ||
| t = self.application.loader.load("project_creation/project_creation.html") |
Contributor
There was a problem hiding this comment.
A more descriptive name for t would be nice
|
|
||
| def get(self): | ||
| # Render the template with the list of forms | ||
| t = self.application.loader.load("project_creation/list_forms.html") |
aanil
reviewed
Dec 30, 2025
| } | ||
| }, | ||
| methods: { | ||
| async onInputChange(event) { |
Member
There was a problem hiding this comment.
I'm not sure if this function is used anywhere
Create Lab and Researcher if they dont exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the functionality to create a project from a user interface in Genomics Status. The project will be saved in LIMS using the API. Since the projects are always editable in LIMS, potential issues with this feature can be adjusted there.
To create the project, the project coordinator fills out a form (defined as a json document) and presses a submit button. The reason for this feature is that he user interface in LIMS is quite bad, with only a very small section of the form viewable at once. The LIMS UI can also not deprecate some UDF values, so the list of possible values to select can grow very large. The genstat UI will use the full page to load the form, be able to deprecate values and in addition can assist with auto-filling in values and fetching suggestions. Some fields in the form will also only be viewable if some conditions are met.
In addition, a fairly complex feature to edit these forms is introduced. This will update the form json document in statusdb.