Skip to content

feat: support import.meta.hot.data for persistent objects across hmr updates #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NathanWalker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support import.meta.hot.data for persistent objects across hmr updates #329

NathanWalker wants to merge 1 commit into from
+121 −25

Conversation

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Dec 15, 2025

Improve the stability and correctness of Hot Module Replacement (HMR) and HTTP module loading.

HMR key normalization and stability

  • Introduced a new canonicalization routine for HMR keys in InitializeImportMetaHot, ensuring that per-module hot.data persists across HMR updates by stripping fragments, normalizing dev endpoint paths
  • Updated all HMR callback and data property registrations to use the canonicalized key, preventing issues where module updates would not propagate due to key mismatches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanWalker