Skip to content

Conversation

@umsungjun
Copy link
Contributor

  • Add JSDoc documentation to isUndefined function
  • Create isUndefined.test.ts to verify function correctness
  • Create isUndefined.bench.ts for performance comparison against lodash's isUndefined
스크린샷 2025-07-31 오후 3 52 47

- Add JSDoc documentation to isUndefined function
- Create isUndefined.test.ts to verify function correctness
- Create isUndefined.bench.ts for performance comparison against lodash's isUndefined
@umsungjun umsungjun requested a review from a team as a code owner July 31, 2025 06:54
@github-actions
Copy link
Contributor

✅ All utility modules are properly registered in index.ts and package.json exports!

@github-actions
Copy link
Contributor

Benchmark Results

Method Test Performance Comparison hidash ops/sec lodash@4.17.21 ops/sec
filter src/filter.bench.ts > filter performance hidash is 2.51x faster 16.43 🏆 6.54
isUndefined src/isUndefined.bench.ts > isUndefined performance hidash is 9.08x faster 9917.96 🏆 1092.31

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/filter.bench.ts",
      "groups": [
        {
          "fullName": "src/filter.bench.ts > filter performance",
          "benchmarks": [
            {
              "id": "-1531020664_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 4.307748527080575,
              "samples": [],
              "totalTime": 608.6889959999999,
              "min": 59.03295600000001,
              "max": 70.23140000000001,
              "hz": 16.42875107931145,
              "period": 60.868899599999985,
              "mean": 60.868899599999985,
              "variance": 13.43712586383411,
              "sd": 3.6656685425491093,
              "sem": 1.159186174168503,
              "df": 9,
              "critical": 2.262,
              "moe": 2.6220791259691536,
              "p75": 60.19620199999997,
              "p99": 70.23140000000001,
              "p995": 70.23140000000001,
              "p999": 70.23140000000001,
              "sampleCount": 10,
              "median": 59.18397500000003
            },
            {
              "id": "-1531020664_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 15.957244029062517,
              "samples": [],
              "totalTime": 1529.5516039999984,
              "min": 118.61097399999971,
              "max": 201.92843300000004,
              "hz": 6.5378637594498645,
              "period": 152.95516039999984,
              "mean": 152.95516039999984,
              "variance": 1164.2837597098182,
              "sd": 34.121602537246375,
              "sem": 10.79019814326789,
              "df": 9,
              "critical": 2.262,
              "moe": 24.40742820007197,
              "p75": 188.3034819999998,
              "p99": 201.92843300000004,
              "p995": 201.92843300000004,
              "p999": 201.92843300000004,
              "sampleCount": 10,
              "median": 142.65087399999993
            }
          ]
        }
      ]
    },
    {
      "filepath": "/home/runner/work/hidash/hidash/src/isUndefined.bench.ts",
      "groups": [
        {
          "fullName": "src/isUndefined.bench.ts > isUndefined performance",
          "benchmarks": [
            {
              "id": "-880671760_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.3689173536031853,
              "samples": [],
              "totalTime": 500.0022640000001,
              "min": 0.09595299999989493,
              "max": 0.2531949999999483,
              "hz": 9917.955091499345,
              "period": 0.10082723613631782,
              "mean": 0.10082723613631782,
              "variance": 0.00017860592415136088,
              "sd": 0.013364352739708754,
              "sem": 0.00018978018942109094,
              "df": 4958,
              "critical": 1.96,
              "moe": 0.0003719691712653382,
              "p75": 0.09962999999999056,
              "p99": 0.1816880000000083,
              "p995": 0.20326900000003434,
              "p999": 0.22215599999998403,
              "sampleCount": 4959,
              "median": 0.09676500000000487
            },
            {
              "id": "-880671760_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 1.6055531966904704,
              "samples": [],
              "totalTime": 500.77477300000055,
              "min": 0.8496860000000197,
              "max": 1.8170279999999366,
              "hz": 1092.3074194074857,
              "period": 0.9154931864716647,
              "mean": 0.9154931864716647,
              "variance": 0.030763434230540527,
              "sd": 0.1753950804057529,
              "sem": 0.00749935210248942,
              "df": 546,
              "critical": 1.96,
              "moe": 0.014698730120879262,
              "p75": 0.8721399999999448,
              "p99": 1.7247610000001714,
              "p995": 1.7270759999998972,
              "p999": 1.8170279999999366,
              "sampleCount": 547,
              "median": 0.8682219999999461
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM =) THX

@yceffort-naver yceffort-naver merged commit 4f0bfc7 into NaverPayDev:main Aug 16, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants