Export all utility functions and types in utils.ts
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chan-hwi
requested review from
a team,
yceffort-naver and
yongholeeme
as code owners
boxersb
reviewed
Dec 31, 2025
src/utils.ts
Outdated
| @@ -1,3 +1,5 @@ | |||
| import NURL from './nurl' | |||
Contributor
There was a problem hiding this comment.
In my opinion, it would be better if the file name were src/utils/index.ts.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! I've changed the folder structure as you suggested in commit c889cbe.
boxersb
approved these changes
Jan 2, 2026
Contributor
boxersb
left a comment
boxersb
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR reflects the discussion about utility function exports from the previous PR comments.
Changes
internal.tsandexternal.tsfor utilities./utilssubpath.matchandmaskutility functions.