Conversation
ZigTag
changed the title
ZigTag
force-pushed
the
workflow/shorten-artifact
branch
from
af13dd2 to
7223421
Compare
ZigTag
force-pushed
the
workflow/shorten-artifact
branch
from
39f7540 to
732c838
Compare
SkySails
reviewed
Jan 20, 2026
Contributor
SkySails
left a comment
SkySails
left a comment
There was a problem hiding this comment.
This does look good!
Could I suggest that we move this zip into the dist folder instead, and update the release workflows? We generally keep "packaged" content in dist, not the root. Seems like we went a different route here for some reason, likely not intentional.
Also, we need to update the title I think 😉
ZigTag
changed the title
SkySails
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could've downgraded bestzip to version v1, but that seemed like a bad idea on an already 4-year-old package, so I switched us over to using a script using cross-zip instead.