[nemesis-generator]: fix issues with nemesis tests failing #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: couple nemesis tests with new nemesis generated
1. test expects the previous block hash to be zeros
2. block verify was failing due using unsigned transactions
solution: update the generator
1. use zero hash for the previous block hash
2. use signed transactions when creating the block signature.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #397 +/- ##
===========================================
+ Coverage 97.88% 100.00% +2.11%
===========================================
Files 17 3 -14
Lines 379 218 -161
Branches 36 0 -36
===========================================
- Hits 371 218 -153
+ Misses 8 0 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Jaguar0625
reviewed
Mar 10, 2025
| writer.write_int(Hash256.SIZE + 4, 4) # needed to deserialize the previous block hash object | ||
| writer.write_int(Hash256.SIZE, 4) | ||
| writer.write_bytes(self.generation_hash.bytes) | ||
| previous_block_hash = Hash256.zero() |
Contributor
There was a problem hiding this comment.
would move this to init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: couple nemesis tests with new nemesis generated
1. test expects the previous block hash to be zeros
2. block verify was failing due using unsigned transactions
solution: update the generator
1. use zero hash for the previous block hash
2. use signed transactions when creating the block signature.