Don't glow dm players #1610
Merged
Don't glow dm players #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunzenshen
approved these changes
Jan 18, 2026
Contributor
sunzenshen
left a comment
sunzenshen
left a comment
There was a problem hiding this comment.
LGTM:
dm-disable-team-xrays.mp4
(Also checked that glows still happen in CTG mode at least.)
Rainyan
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This also fixes a problem where the glows don't update when the game mode changes. a RecvProxy on the m_nGameTypeSelected variable doesn't work, event messages probably could work but they arrive before the neorules data (including the selected game mode) arrives and anyway the developer wiki says to not run entity logic there and to use PostDataUpdate instead, but the comment in the source code describing PostdataUpdate suggests OnDataChanged should be used instead, except the neorules object doesn't extend C_BaseEntity, probably why the game rules proxy exists.
We could probably detect the start of a new round in a similar fashion to how we detect the game mode change here to do stuff that should be done to every player on spawn client side, although a user message could work too not sure which one would be the best way to do it