Fix crosshair not centered when changing resolution again and make slider and ringbox values change faster when clicking them with the mouse #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Used linux_release build https://github.com/NeotokyoRebuild/neo/actions/runs/21038277422 Seems to be working as intended, see screenshots. Pressed Esc after changing to higher res.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would appreciate if some linux person could test this one, just play in windowed and change the resolution from a small resolution to a large resolution, making sure not to open either the options or the find server menu after confirming the settings change as that fixes the crosshair offset on master currently. Not sure how this works but from testing setting the size of the fullscreen viewport to 0 0 seems to reset it to how it was behaving before the size was changed initially by the neoui tabs.
Also if there are any other ui input elements that are behaving sluggishly that I missed let me know. I didn't know if moving the position of the cursor in the text input should be faster or whether we should instead have double click select all text in the input, probably the latter, or maybe double click selects the word and triple click instead selects all text in the input.
Toolchain