Persist validation markers to S3 for UCC. #1122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattl-netflix
force-pushed
the
feature/validation_markers_in_s3
branch
10 times, most recently
from
9d94564 to
783b495
Compare
clohfink
approved these changes
Oct 22, 2025
clohfink
left a comment
clohfink
left a comment
There was a problem hiding this comment.
+1 with some changes you can ignore if disagree
| import javax.inject.Inject; | ||
| import javax.inject.Provider; | ||
|
|
||
| public class SnapshotValidationMarkerWriter { |
There was a problem hiding this comment.
NP: use of Verification instead of Validation other places, rename to maintain consistent terminology
| try { | ||
| fs.putObject(config.getBackupPrefix(), key, remotePath); | ||
| } catch (Exception e) { | ||
| logger.error("Failed to put snapshot verification marker. bucket: {}, key: {}, value: {}, message: {}", |
There was a problem hiding this comment.
This could use a retry since it doesnt provide any metrics or anything to notify and we expect S3 puts to fail sometimes.
There was a problem hiding this comment.
also a success/failure metric might be good to add
Contributor
Author
There was a problem hiding this comment.
Added retries. We can metrics implicitly when we centralize validation and include these in the checks.
IMO we can justify stacking a bet here because this is meant as a fallback rather than the main mechanism to get these data.
mattl-netflix
force-pushed
the
feature/validation_markers_in_s3
branch
from
f21eb07 to
d998c72
Compare
mattl-netflix
force-pushed
the
feature/validation_markers_in_s3
branch
from
d998c72 to
558d7ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This persists an alternative location for backup metadata in S3 in case of unavailability of the primary source of truth. Tests are in progress and will be added in a follow-up commit. I have confirmed it WAI in practice.