Migrating to new S3 SDK

[sinchanah-dot]

1. Package Changes:
   • com.amazonaws.services.s3 → software.amazon.awssdk.services.s3
   • com.amazonaws.auth → software.amazon.awssdk.auth.credentials
2. Client Creation:
   - AmazonS3Client.builder() → S3Client.builder()
   - .withCredentials() → .credentialsProvider()
   - .withRegion() → .region()
3. Request/Response Pattern:
   - Mutable objects → Immutable builders
   - new PutObjectRequest(bucket, key) → PutObjectRequest.builder().bucket(bucket).key(key).build()
4. Method Naming:
   - .getXxx() → .xxx() (no "get" prefix in SDK v2)
   - .setXxx() → Builder pattern
5. Exceptions:
   - AmazonClientException → SdkException
   - AmazonServiceException → S3Exception

Test changes:

1. Created FakeS3Credential.java - A test credential implementation that provides fake AWS credentials for testing using SDK v2 APIs.
2. Updated TestS3FileSystem.java:
   - Changed imports from SDK v1 to SDK v2
   - Updated MockS3PartUploader to use CompletedPart instead of PartETag
   - Updated MockAmazonS3Client to mock S3Client (SDK v2) instead of AmazonS3Client
   - Updated all exception types and response builders
3. Updated BRTestModule.java:
   - Added binding for IS3Credential with @nAmed("s3") annotation to FakeS3Credential
   - Kept the existing binding for role assumption
4. Updated S3RoleAssumptionCredential.java:
   - Added @nAmed("s3") annotation to the constructor parameter
   - Added missing import for javax.inject.Named

[sinchanah-dot]

• Added AWS SDK v2 dependencies (BOM platform, s3, sts)
• Kept AWS SDK v1 dependencies for EC2, AutoScaling, SNS, and core services
• Created hybrid SDK environment supporting both v1 and v2 simultaneously

[sinchanah-dot]

• Updated constructor to inject IS3Credential with @nAmed("awss3roleassumption")
• Changed S3 client initialization to use S3Client.builder() with explicit region
• Updated downloadFileImpl() to use RangeReadInputStream with SDK v2 client
• Updated uploadMultipart() to use CreateMultipartUploadRequest builder and CompletedPart list
• Updated uploadFileImpl() to use PutObjectRequest builder and RequestBody.fromBytes()
• Updated metadata handling to use SDK v2 patterns

[sinchanah-dot]

• Changed AmazonS3 client to S3Client
• Updated getFileSize() to use HeadObjectRequest with builder pattern
• Updated doesRemoteFileExist() to use SDK v2 builders and exception types (NoSuchKeyException)
• Updated deleteFiles() to use ObjectIdentifier and Delete builders

[sinchanah-dot]

• Changed ObjectListing to ListObjectsResponse
• Changed client type from AmazonS3 to S3Client
• Updated initListing() to use ListObjectsRequest builder
• Changed S3ObjectSummary to S3Object
• Updated method calls (getObjectSummaries() → contents(), getKey() → key())
• Replaced listNextBatchOfObjects() with manual pagination using nextMarker()

[sinchanah-dot]

• Changed client type from AmazonS3 to S3Client
• Changed List to List
• Updated uploadPart() to use SDK v2 request builders and RequestBody
• Updated completeUpload() to use CompletedMultipartUpload builder
• Updated abortUpload() to use SDK v2 request builder
• Changed exception types from AmazonClientException to SdkException

[sinchanah-dot]

• Changed client type from AmazonS3 to S3Client
• Updated read() method to use GetObjectRequest builder
• Changed range format from .setRange(start, end) to .range("bytes=start-end")
• Changed response type from S3ObjectInputStream to ResponseInputStream

[sinchanah-dot]

• Implements IS3Credential for instance profile credentials
• Uses SDK v2's InstanceProfileCredentialsProvider

[sinchanah-dot]

• Implements IS3Credential for STS role assumption
• Uses SDK v2's StsClient and StsAssumeRoleCredentialsProvider
• Handles automatic credential refresh
• Added @nAmed("s3") annotation to constructor for dependency injection

[sinchanah-dot]

• Created new interface for S3-specific credentials using SDK v2
• Defines methods for getting AwsCredentials and AwsCredentialsProvider (SDK v2 types)

[mattl-netflix]

I'm not completely done here, but I wanted to unblock you to the extent possible.

[mattl-netflix]

Put imports in alphabetical order. Ctrl-Opt-o in intellij.

[sinchanah-dot]

This is in alphabetical order right? software.* comes after org.*

[mattl-netflix]

There are two types of comments worth writing:

1. Explaining why something was implemented in a way that isn't the simplest possible.
2. Javadoc for automated documentation.

Anything explaining what the subsequent code does (redundant as it is obvious by inspection), any links (rot-prone), why something is present (because it is totally essential) should just be omitted as they make it harder to parse the code.

Please delete all comments you have added.

[mattl-netflix]

Please refactor this and the equivalent code in generatePut() into subroutine akin to getObjectMetadata() in the original code.

It looks like that might have been your intention with getObjectMetadataBuilder() all along.

[mattl-netflix]

Just confirming explicitly my original review is complete. Let's just work on vetting it. We can meet tomorrow to check up on that and maybe parallelize some work if you like.