Skip to content

Rename Functions & Add Const Correctness #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecbadeaux merged 2 commits into from
Jul 11, 2025
Merged

Rename Functions & Add Const Correctness #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c362d8
Rename Registry Functions
ecbadeaux Jul 10, 2025
7e56cf6
Rename functions
ecbadeaux Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion performance_tests/performance_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ int main(int argc, char* argv[])
{
while (should_stop == false)
{
r.counter(config->counterName, tags).Increment();
r.CreateCounter(config->counterName, tags).Increment();
iterations.fetch_add(1, std::memory_order_relaxed);
}
};
Expand Down
62 changes: 31 additions & 31 deletions spectator/registry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Registry::Registry(const Config& config) : m_config(config)
}
}

MeterId Registry::new_id(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
MeterId Registry::CreateNewId(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
{
MeterId new_meter_id(name, tags);

Expand All @@ -66,89 +66,89 @@ MeterId Registry::new_id(const std::string& name, const std::unordered_map<std::
return new_meter_id.WithTags(this->m_config.GetExtraTags());
}

AgeGauge Registry::age_gauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
AgeGauge Registry::CreateAgeGauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
{
return AgeGauge(new_id(name, tags));
return AgeGauge(CreateNewId(name, tags));
}

AgeGauge Registry::age_gauge_with_id(const MeterId& meter_id) { return AgeGauge(meter_id); }
AgeGauge Registry::CreateAgeGauge(const MeterId& meter_id) const { return AgeGauge(meter_id); }

Counter Registry::counter(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
Counter Registry::CreateCounter(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
{
return Counter(new_id(name, tags));
return Counter(CreateNewId(name, tags));
}

Counter Registry::counter_with_id(const MeterId& meter_id) { return Counter(meter_id); }
Counter Registry::CreateCounter(const MeterId& meter_id) const { return Counter(meter_id); }

DistributionSummary Registry::distribution_summary(const std::string& name,
DistributionSummary Registry::CreateDistributionSummary(const std::string& name,
const std::unordered_map<std::string, std::string>& tags) const
{
return DistributionSummary(new_id(name, tags));
return DistributionSummary(CreateNewId(name, tags));
}

DistributionSummary Registry::distribution_summary_with_id(const MeterId& meter_id)
DistributionSummary Registry::CreateDistributionSummary(const MeterId& meter_id) const
{
return DistributionSummary(meter_id);
}

Gauge Registry::gauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags,
Gauge Registry::CreateGauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags,
const std::optional<int>& ttl_seconds) const
{
return Gauge(new_id(name, tags), ttl_seconds);
return Gauge(CreateNewId(name, tags), ttl_seconds);
}

Gauge Registry::gauge_with_id(const MeterId& meter_id, const std::optional<int>& ttl_seconds)
Gauge Registry::CreateGauge(const MeterId& meter_id, const std::optional<int>& ttl_seconds) const
{
return Gauge(meter_id, ttl_seconds);
}

MaxGauge Registry::max_gauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
MaxGauge Registry::CreateMaxGauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
{
return MaxGauge(new_id(name, tags));
return MaxGauge(CreateNewId(name, tags));
}

MaxGauge Registry::max_gauge_with_id(const MeterId& meter_id) { return MaxGauge(meter_id); }
MaxGauge Registry::CreateMaxGauge(const MeterId& meter_id) const { return MaxGauge(meter_id); }

MonotonicCounter Registry::monotonic_counter(const std::string& name,
MonotonicCounter Registry::CreateMonotonicCounter(const std::string& name,
const std::unordered_map<std::string, std::string>& tags) const
{
return MonotonicCounter(new_id(name, tags));
return MonotonicCounter(CreateNewId(name, tags));
}

MonotonicCounter Registry::monotonic_counter_with_id(const MeterId& meter_id) { return MonotonicCounter(meter_id); }
MonotonicCounter Registry::CreateMonotonicCounter(const MeterId& meter_id) const { return MonotonicCounter(meter_id); }

MonotonicCounterUint Registry::monotonic_counter_uint(const std::string& name,
MonotonicCounterUint Registry::CreateMonotonicCounterUint(const std::string& name,
const std::unordered_map<std::string, std::string>& tags) const
{
return MonotonicCounterUint(new_id(name, tags));
return MonotonicCounterUint(CreateNewId(name, tags));
}

MonotonicCounterUint Registry::monotonic_counter_uint_with_id(const MeterId& meter_id)
MonotonicCounterUint Registry::CreateMonotonicCounterUint(const MeterId& meter_id) const
{
return MonotonicCounterUint(meter_id);
}

PercentileDistributionSummary Registry::pct_distribution_summary(
PercentileDistributionSummary Registry::CreatePercentDistributionSummary(
const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
{
return PercentileDistributionSummary(new_id(name, tags));
return PercentileDistributionSummary(CreateNewId(name, tags));
}

PercentileDistributionSummary Registry::pct_distribution_summary_with_id(const MeterId& meter_id)
PercentileDistributionSummary Registry::CreatePercentDistributionSummary(const MeterId& meter_id) const
{
return PercentileDistributionSummary(meter_id);
}

PercentileTimer Registry::pct_timer(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
PercentileTimer Registry::CreatePercentTimer(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
{
return PercentileTimer(new_id(name, tags));
return PercentileTimer(CreateNewId(name, tags));
}

PercentileTimer Registry::pct_timer_with_id(const MeterId& meter_id) { return PercentileTimer(meter_id); }
PercentileTimer Registry::CreatePercentTimer(const MeterId& meter_id) const { return PercentileTimer(meter_id); }

Timer Registry::timer(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
Timer Registry::CreateTimer(const std::string& name, const std::unordered_map<std::string, std::string>& tags) const
{
return Timer(new_id(name, tags));
return Timer(CreateNewId(name, tags));
}

Timer Registry::timer_with_id(const MeterId& meter_id) { return Timer(meter_id); }
Timer Registry::CreateTimer(const MeterId& meter_id) const { return Timer(meter_id); }
42 changes: 21 additions & 21 deletions spectator/registry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,63 +19,63 @@ class Registry
explicit Registry(const Config& config);
~Registry() = default;

MeterId new_id(const std::string& name, const std::unordered_map<std::string, std::string>& tags = {}) const;
MeterId CreateNewId(const std::string& name, const std::unordered_map<std::string, std::string>& tags = {}) const;

AgeGauge age_gauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
AgeGauge CreateAgeGauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
std::unordered_map<std::string, std::string>()) const;

static AgeGauge age_gauge_with_id(const MeterId& meter_id);
AgeGauge CreateAgeGauge(const MeterId& meter_id) const;

Counter counter(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
Counter CreateCounter(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
std::unordered_map<std::string, std::string>()) const;

static Counter counter_with_id(const MeterId& meter_id);
Counter CreateCounter(const MeterId& meter_id) const;

DistributionSummary distribution_summary(
DistributionSummary CreateDistributionSummary(
const std::string& name,
const std::unordered_map<std::string, std::string>& tags = std::unordered_map<std::string, std::string>()) const;

static DistributionSummary distribution_summary_with_id(const MeterId& meter_id);
DistributionSummary CreateDistributionSummary(const MeterId& meter_id) const;

Gauge gauge(
Gauge CreateGauge(
const std::string& name,
const std::unordered_map<std::string, std::string>& tags = std::unordered_map<std::string, std::string>(),
const std::optional<int>& ttl_seconds = std::nullopt) const;

static Gauge gauge_with_id(const MeterId& meter_id, const std::optional<int>& ttl_seconds = std::nullopt);
Gauge CreateGauge(const MeterId& meter_id, const std::optional<int>& ttl_seconds = std::nullopt) const;

MaxGauge max_gauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
MaxGauge CreateMaxGauge(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
std::unordered_map<std::string, std::string>()) const;

static MaxGauge max_gauge_with_id(const MeterId& meter_id);
MaxGauge CreateMaxGauge(const MeterId& meter_id) const;

MonotonicCounter monotonic_counter(
MonotonicCounter CreateMonotonicCounter(
const std::string& name,
const std::unordered_map<std::string, std::string>& tags = std::unordered_map<std::string, std::string>()) const;

static MonotonicCounter monotonic_counter_with_id(const MeterId& meter_id);
MonotonicCounter CreateMonotonicCounter(const MeterId& meter_id) const;

MonotonicCounterUint monotonic_counter_uint(
MonotonicCounterUint CreateMonotonicCounterUint(
const std::string& name,
const std::unordered_map<std::string, std::string>& tags = std::unordered_map<std::string, std::string>()) const;

static MonotonicCounterUint monotonic_counter_uint_with_id(const MeterId& meter_id);
MonotonicCounterUint CreateMonotonicCounterUint(const MeterId& meter_id) const;

PercentileDistributionSummary pct_distribution_summary(
PercentileDistributionSummary CreatePercentDistributionSummary(
const std::string& name,
const std::unordered_map<std::string, std::string>& tags = std::unordered_map<std::string, std::string>()) const;

static PercentileDistributionSummary pct_distribution_summary_with_id(const MeterId& meter_id);
PercentileDistributionSummary CreatePercentDistributionSummary(const MeterId& meter_id) const;

PercentileTimer pct_timer(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
PercentileTimer CreatePercentTimer(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
std::unordered_map<std::string, std::string>()) const;

static PercentileTimer pct_timer_with_id(const MeterId& meter_id);
PercentileTimer CreatePercentTimer(const MeterId& meter_id) const;

Timer timer(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
Timer CreateTimer(const std::string& name, const std::unordered_map<std::string, std::string>& tags =
std::unordered_map<std::string, std::string>()) const;

static Timer timer_with_id(const MeterId& meter_id);
Timer CreateTimer(const MeterId& meter_id) const;

private:
Config m_config;
Expand Down
Loading