Skip to content

Jc/refac catalyst docker build #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmjustinchan merged 2 commits into from
Jan 22, 2026
Merged

Jc/refac catalyst docker build #806

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
659b8a5
refac: add short commit hash as tag for docker build
nmjustinchan Jan 22, 2026
ad337fd
fix: image not found in staging when using commit hash
nmjustinchan Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .github/workflows/node_docker_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,16 @@ jobs:
${{ needs.build.outputs.digest-amd64 }} \
${{ needs.build.outputs.digest-arm64 }}

- name: Tag with commit SHA
run: |
SHORT_SHA="${{ github.sha }}"
SHORT_SHA=${SHORT_SHA:0:7}
SHA_TAG="sha-${SHORT_SHA}"
docker buildx imagetools create \
-t ${DOCKER_REGISTRY}/${DOCKER_REPOSITORY_STAGING}:${SHA_TAG} \
${{ needs.build.outputs.digest-amd64 }} \
${{ needs.build.outputs.digest-arm64 }}

- name: Setup ORAS
uses: oras-project/setup-oras@v1

Expand All @@ -128,12 +138,14 @@ jobs:
- name: Determine tags to promote
id: promote-tags
run: |
SHORT_SHA="${{ github.sha }}"
SHORT_SHA=${SHORT_SHA:0:7}
SHA_TAG="sha-${SHORT_SHA}"
if [[ "${{ github.ref }}" == refs/tags/* ]]; then
VERSION=${GITHUB_REF#refs/tags/}
BASE_VERSION=${VERSION%}
echo "TAGS=latest $BASE_VERSION" >> $GITHUB_ENV
echo "TAGS=$VERSION $SHA_TAG" >> $GITHUB_ENV
else
echo "TAGS=latest" >> $GITHUB_ENV
echo "TAGS=latest $SHA_TAG" >> $GITHUB_ENV
fi

- name: Login to Dockerhub registry with ORAS
Expand All @@ -144,12 +156,16 @@ jobs:

- name: Promote to Dockerhub Production
run: |
set -e
for tag in $TAGS; do
echo "Current tag: $tag"
source_image="${DOCKER_REGISTRY}/${DOCKER_REPOSITORY_STAGING}:${tag}"
prod_image="${DOCKER_PUBLIC_REGISTRY}/${DOCKER_PUBLIC_REPOSITORY}:${tag}"
echo "Promoting ${source_image} to ${prod_image}"
oras cp -r "${source_image}" "${prod_image}"
if ! oras cp -r "${source_image}" "${prod_image}"; then
echo "Error: Failed to promote tag ${tag}" >&2
exit 1
fi
done

- name: Summary
Expand Down
Loading