Conversation
Replaces the previous GetHashCode logic with a hardware-accelerated approach using AES instructions on supported platforms (x64 and ARM), and improves the fallback CRC32C-based hash with better mixing and finalization. This enhances hash quality, performance, and diffusion for UInt256 values.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the UInt256.GetHashCode implementation by introducing hardware-accelerated AES-based hashing for x64 and ARM platforms while improving the fallback CRC32C implementation with better mixing and finalization.
Changes:
- Adds AES hardware intrinsics support for x64 and ARM platforms to compute hash codes using encryption operations
- Improves the CRC32C fallback path with distinct seeds per component and better mixing/finalization
- Introduces using aliases (
x64andArm) for intrinsics namespaces
benaadams
changed the title
rubo
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the previous GetHashCode logic with a hardware-accelerated approach using AES instructions on supported platforms (x64 and ARM), and improves the fallback CRC32C-based hash with better mixing and finalization. This enhances hash quality, performance, and diffusion for UInt256 values.