-
Notifications
You must be signed in to change notification settings - Fork 266
Better error intan when missing files in the "one-file-per-signal" type. #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Maybe there are some missing ones that are acceptable. But I think we can start here and be explicit which is better. |
|
I think this is a tough check to make carefully. For one-file-per-channel you can basically shut anything off. For one-file-per-signal that are certain combination that have to show up together but you could shut off dig in /dig out, aux channels. So I think don't think we have a realistic core. I think we should pull the info from the header and whatever the header says is enabled we raise an error no? We do that when we read the header. Most things have a boolean check to see if that signal is enabled? |
|
Look at line 1185 for the check I'm referring to. We see that the signal is enable. Then we could use that information for the formats I think. Maybe you could try an implementation with that instead? |
Yeah, this is the case that I want to cover. one-file-per-channel seems too complicated at the moment but might do it later.
Yes, this is the way. Thanks. |
|
@h-mayorquin you still want to work on this before release next week? Or kick this to next version? |
|
Thanks for the reminder. Most likely will need to wait for the next version. |
|
yesterday we discussed trying to include this in the release coming out in the next couple weeks. Will you have time to finish this or should I kick this to the Mar/Apr release? |

From the discussion on #1693, @zm711