Nonlinear regression simulations for existing split criteria#29
Open
Nonlinear regression simulations for existing split criteria#29
Conversation
Author
Split Criteria Comparison Experiment and ResultsFor each simulation type (Logarithmic, Sine, Square, Multiplicative, Independence)
|
eigenvivek
reviewed
Mar 17, 2020
examples/ensemble/plot_random_forest_regression_criteria_comparison.py
Outdated
Show resolved
Hide resolved
eigenvivek
reviewed
Mar 17, 2020
examples/ensemble/plot_random_forest_regression_criteria_comparison.py
Outdated
Show resolved
Hide resolved
eigenvivek
reviewed
Mar 17, 2020
examples/ensemble/plot_random_forest_regression_criteria_comparison.py
Outdated
Show resolved
Hide resolved
eigenvivek
reviewed
Mar 17, 2020
examples/ensemble/plot_random_forest_regression_criteria_comparison.py
Outdated
Show resolved
Hide resolved
eigenvivek
reviewed
Mar 17, 2020
eigenvivek
previously requested changes
Mar 17, 2020
eigenvivek
left a comment
There was a problem hiding this comment.
Overall, it looks great! I made some minor comments asking for stylistic changes to the comments.
Member
|
This looks great. I think you wanted to make a PR to real sklearn right? My only concern is that the current NDD master has bunch of changes from other people that would be merged in as well. For this, I think the best course of action is to make a new branch, fetch the latest sklearn, add in these two examples along with the data generation code. Then make the PR from that branch. |
These changes have been made in both the real sklearn version and the NDD version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reference Issues/PRs
Fixes Issue 16370 in scikit-learn. Also see Issue 2 in tealeaf.
What does this implement/fix? Explain your changes.
This PR adds simulations and plots that show how split criteria compare on several nonlinear regression simulations including sinusoidal, logarithmic, multiplicative, and independence. There is not much information on scikit-learn's documentation about how to go about choosing which to use (mse, mae, or friedman mse) for the
criterionparameter. This example demonstrates how to go about finding differences and shows that it may not always matter which criterion is chosen.Any other comments?
This PR in
sklearnwill include these files:The other files that were changed for Vivek's PR will not be changed in sklearn.