Skip to content
This repository was archived by the owner on Jan 14, 2020. It is now read-only.

Adds Short Link Subdomain#412

Open
redreceipt wants to merge 1 commit intodevelopfrom
short-link-domain
Open

Adds Short Link Subdomain#412
redreceipt wants to merge 1 commit intodevelopfrom
short-link-domain

Conversation

@redreceipt
Copy link
Contributor

DESCRIPTION

What does this PR do, or why is it needed?

How do I test this PR?

TODO

  • I am affirming this is my best work (Ecclesiastes 9:10)
  • PR has a relevant title that will be understandable in a public changelog (ie...non developers)
  • No new warnings in tests, in storybook, and in-app
  • Upload GIF(s) of iOS and Android if applicable
  • Set a relevant reviewer

REVIEW

  • Review updates to test coverage and snapshots
  • Review code through the lens of being concise, simple, and well-documented

Manual QA

  • Manual QA on iOS and ensure it looks/behaves as expected
  • Manual QA on Android and ensure it looks/behaves as expected

The purpose of PR Review is to improve the quality of the software.

@redreceipt redreceipt added the ready for review This is ready to be reviewd label Nov 21, 2019
@redreceipt redreceipt mentioned this pull request Nov 21, 2019
9 tasks
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@1054f37). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #412   +/-   ##
==========================================
  Coverage           ?   44.15%           
==========================================
  Files              ?      174           
  Lines              ?     1710           
  Branches           ?      186           
==========================================
  Hits               ?      755           
  Misses             ?      840           
  Partials           ?      115

@redreceipt redreceipt added the blocked Blocked by another PR label Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

blocked Blocked by another PR ready for review This is ready to be reviewd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants