Skip to content

Conversation

@ahmadalibaloch
Copy link

Before this edit we can add placeholder-value to custom fields but using the ui list input with an auto-generated text element did not allow to add a placeholder simply because the auto generated element template was not complete with a placeholder.
Now after edit a user can add a placeholder attribute like in any HTML input in the main div beside ng-model attribute.

Before this edit we can add placeholder-value to custom fields but using the ui list input with an auto-generated text element did not allow to add a placeholder simply because the auto generated element template was not complete with a placeholder.
Now after edit a user can add a placeholder attribute like in any HTML input in the main div beside ng-model attribute.
@idpaterson
Copy link
Contributor

Thanks for the pull request, I hope the directive has been useful to you.

Can you add tests covering the various ways that a placeholder might be specified? For example:

placeholder="Full Name"
placeholder="{{fieldName}}"
placeholder=""Nickname""

This approach does not seem like the right way to expose the placeholder for general-purpose use.

@ahmadalibaloch
Copy link
Author

Well, the placeholder can be added just like we add a placeholder or any
other attribute but the value of the placeholder attribute is given in
single quotes.
Here is how I am using it:

so you can add a placeholde attribute to the div as
placeholder="'your place holder'"

Thanks.

On Mon, Oct 20, 2014 at 5:04 PM, Ian Paterson notifications@github.com
wrote:

Thanks for the pull request, I hope the directive has been useful to you.

Can you add tests covering the various ways that a placeholder might be
specified? For example:

placeholder="Full Name"
placeholder="{{fieldName}}"
placeholder=""Nickname""

This approach does not seem like the right way to expose the placeholder
for general-purpose use.

Reply to this email directly or view it on GitHub
#2 (comment)
.

Ahmad Ali, Software Engineer www.expertflow.com Lahore, Pakistan

Mobile: +92344***940 | *Email: ahmad.ali@expertflow.com | Skype:
ahmadalibaloch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants