경험/문항/채팅 API 데이터 레이어 구현 #16
Open
+1,055
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Chatting Source
- Json provide 메서드 - ConverterFactory 부착 - CallAdapterFactory 부착
- 매핑 로직 - Experience 도메인 모델 - Hilt 모듈
Hyesung82
reviewed
Jan 26, 2026
| internal interface RepositoryModule { | ||
|
|
||
| @Binds | ||
| @ActivityScoped |
There was a problem hiding this comment.
ActivityRetainedComponent는 화면 회전 시에도 유지되게 하는 설정값이고 ActivityScoped는 무조건 Activity 생명주기에 따라 소멸하는 설정값인 것 같은데(잘 모름)
이거 혹시 @ActivityRetainedScoped를 써야 의도대로 동작하지 않을까요?
|
|
||
| fun startChattingStream(questionId: String, sendingMessage: String): Flow<ChattingStreaming> | ||
| suspend fun getChatHistory(questionId: String): Result<ChattingHistory> | ||
| suspend fun updateLetter(chattingId: String, questionId: String, content: String): Result<Unit> |
There was a problem hiding this comment.
혹시 이게 자소서 업데이트하는 함수라면 updatePaper로 이름 지으면 어떨까요?
왜냐하면 Figma에서 자소서 아이콘 이름이 paper라서.. ㅎㅎ
아니면 아예 cover letter라고 표현하는 것도 괜찮을 것 같습니다
Member
Author
There was a problem hiding this comment.
이게 백엔드에서는 Draft로 표현하는거 같더라구요 ...
일단 다같이 얘기를 해봐야할듯 합니다 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
내용
위 API들에 대한 데이터 레이어 구조를 구현했습니다 (Repository - DataSource - Retrofit)
[또 1000줄을 넘겨버렸는데... 대부분 단순 중복이라 훅훅 넘겨주세요 ㅠ]