Fixes to bugs found recently and license#127
Merged
NiklasPfister merged 9 commits intoNiklasPfister:Developmentfrom May 28, 2025
Merged
Fixes to bugs found recently and license#127NiklasPfister merged 9 commits intoNiklasPfister:Developmentfrom
NiklasPfister merged 9 commits intoNiklasPfister:Developmentfrom
Conversation
Version update to 1.5.0
This bug makes it such that we don't build
np-lakera
approved these changes
May 28, 2025
np-lakera
left a comment
np-lakera
left a comment
There was a problem hiding this comment.
Tested and everything works. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 3 main bug fixes in this pull request:
1.
segmentation fault when honest_tree sampling with low amount of datapoints. This issue was due to the predictor.root not being updated after refitting the leaf nodes, so in the case that the root node after a refit was different than previously, then the predictor.root would point to an invalid node.
Default sampling parameters fails when reused.
This was due to the way numpy integers work. The check isinstance(val, int) returns false on any type of numpy integer.
Fix: added np.integer to the checks, such that we check isinstance(val, (int, np.integer))
refit_leaf_nodes expected np.int64, but generally we work with np.int32. Changed the RandomForest to now use the default np.int32, and changed the expected type of sample_indices to the np.int32.