Conversation
pablojhl
force-pushed
the
fix/eddsa-signatures
branch
from
91f0514 to
28dfe3d
Compare
pablojhl
requested review from
andreasbros,
jfdreis,
lumasepa,
mfontanini and
tim-hm
lumasepa
approved these changes
Mar 21, 2025
jimouris
approved these changes
Mar 24, 2025
pablojhl
force-pushed
the
fix/eddsa-signatures
branch
from
28dfe3d to
4a8ea83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the eddsa tests.
The main issue is that
NadaValue::create_eddsa_private_key()works only with modular scalars, whilenoble/ed25519.util.randomPrivateKey()generates seed that can be greater than the curve order. For now, I have implemented a utility to calculate a valid scalar.Not sure if it would make sense, but if a user wanted to store this seed in the future we would have to revisit the nilvm implementation.