Fixed race condition in deferred link detection#3
Open
fluidsonic wants to merge 2 commits intoNimbusKit:masterfrom
fluidsonic:master
Open
Fixed race condition in deferred link detection#3fluidsonic wants to merge 2 commits intoNimbusKit:masterfrom fluidsonic:master
fluidsonic wants to merge 2 commits intoNimbusKit:masterfrom
fluidsonic:master
Conversation
Author
|
@jverkoey any news here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a label's text is updated while the deferred link detection is still in progress the app most likely crashes.
detectedlinkLocationswould contain the text checking results of the previous text - not the current one. So it's text ranges are no longer valid which in turn leads to a crash when using them e.g. for applying link styles.Also the new text wasn't link-checked automatically since the previous link detection was not yet complete.