Open
Conversation
Author
|
I think we might need a follow up to fix the centering for the selections in the web map view. |
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of the josm-seachart does not support virtual AtoNs. I did find however, a newer version that does:
I am not sure this is something that interests the main project but it has minimal code from my side and it does seems to do the job. That is it will generate icons when the "seamark:ref" is set to "virtual_aton".
SInce the virtual AtoN icons are larger though, I had to tweak the icon generation so that it centers and positions the icons a bit differently.
I need to be able to differentiate between AtoNs and VAtoNs to make the latter slightly smaller. Also the icons are now completely centered, so the buoys do appear slightly higher in the generated images. Finally I increased a bit the width of the generated images, so that they fit.