RFC: new saving/loading of save file variables. #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Expression has issues with VERSION. I'd suggest making VERSION return a string. Then you add RELEASE. All subelements will return a double or int. So 0 is major, 9 is minor and 3 is release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits up variables in five nodes: numbers, strings, bools, kostypes and variables. The latter is for when it's not the first four. That is for debugging and can be removed. It casts the strings to string,numbers to double and bools to bool, putting kostypes through Expression.
This fixes #220 as far as i can tell at the cost of breaking old saves. Anyone know how to convert in a reasonable way? I'll link a compiled dll upon request.