ocamlPackages: Update dependencies for Coccinelle #197184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: ocaml
ofborg
bot
added
10.rebuild-darwin: 1-10
vbgl
reviewed
Oct 22, 2022
https://github.com/thierry-martinez/pyml/releases/tag/20220905 Aldo switch to dune, which has been available since 2021-09-24. And remove unneeded dependencies: - ncurses was needed for Python in the past - ocaml and findlib are implied by dune
Member
Author
|
Looks like the dune build system does not install top-levels. Not sure if those are necessary. |
Member
Author
|
I tried to fix that but got stuck. From the warning in https://github.com/thierry-martinez/pyml/pull/87, it looks like that |
Member
Author
|
The following includes the --- a/pkgs/development/tools/ocaml/utop/default.nix
+++ b/pkgs/development/tools/ocaml/utop/default.nix
@@ -57,6 +57,10 @@ buildDunePackage rec {
done
'';
+ postPatch = ''
+ sed -Ei '/modes byte/d' src/lib/dune
+ '';
+
meta = {
description = "Universal toplevel for OCaml";
longDescription = ''but pymlutop still fails to build: |
Contributor
|
What’s the status of this? The first commit looks good and could be merged (it makes |
Member
Author
|
Unless there is need for toplevels (I am still not completely sure what they are for), it should be okay to merge as is. |
Contributor
|
Thanks. |
1 task
Contributor
|
Successfully created backport PR #205912 for |
Contributor
|
Git push to origin failed for release-22.11 with exitcode 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes