Skip to content

Fix coqPackages.mathcomp-altreals dependencies#352090

Merged
vbgl merged 1 commit intoNixOS:masterfrom
proux01:fix-altreals
Oct 29, 2024
Merged

Fix coqPackages.mathcomp-altreals dependencies#352090
vbgl merged 1 commit intoNixOS:masterfrom
proux01:fix-altreals

Conversation

@proux01
Copy link
Contributor

@proux01 proux01 commented Oct 29, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from CohenCyril October 29, 2024 14:52
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 29, 2024
@proux01
Copy link
Contributor Author

proux01 commented Oct 29, 2024

@vbgl CI green both here and on rocq-community/coq-nix-toolbox#279 (and this time I didn't forget to test master on math-comp/analysis#1373 ), sorry about my stupid mistake

@proux01 proux01 marked this pull request as ready for review October 29, 2024 15:48
@vbgl vbgl merged commit 46143dd into NixOS:master Oct 29, 2024
@proux01
Copy link
Contributor Author

proux01 commented Oct 29, 2024

Thanks

@proux01 proux01 deleted the fix-altreals branch October 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants