pythonPackages.atomman: init at 1.2.3#48183
Merged
dotlambda merged 3 commits intoNixOS:masterfrom Oct 31, 2018
Merged
Conversation
FRidh
suggested changes
Oct 13, 2018
89e44dd to
e9f3562
Compare
Member
Author
|
Package name normalize and ready for merge. |
dotlambda
requested changes
Oct 30, 2018
Member
dotlambda
left a comment
There was a problem hiding this comment.
Commit message needs to be fixed and merge conflict needs to be resolved.
dotlambda
reviewed
Oct 30, 2018
Member
There was a problem hiding this comment.
You should enable tests once a new version with this PR merged is released.
e9f3562 to
1ac9d8e
Compare
Member
Author
|
@dotlambda fixed merge conflict. I will create a new PR later to include tests if atomman adds them. |
Member
|
@GrahamcOfBorg build python2.pkgs.atomman python3.pkgs.atomman |
|
Success on x86_64-darwin (full log) Attempted: python2.pkgs.atomman, python3.pkgs.atomman Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.atomman, python3.pkgs.atomman Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: python2.pkgs.atomman, python3.pkgs.atomman Partial log (click to expand)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Material science python packages for molecular dynamics.
Things done
pythonPackages.numericalunits: init at 1.16
pythonPackages.DataModelDict: init at 0.9.4
pythonPackages.atomman: init at 1.2.3
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)