The CellID can have leading zeros#4
Open
evenly-epic-mule wants to merge 1 commit intoNoctem:masterfrom
Open
Conversation
e.g. spawn_point_id 0x "4xxxxxxxxxx" = 0b0100 would be shifted by 21 while spawn_point_id 0x "8xxxxxxxxxx" = 0b1000 would be shifted by 20 cellid_to_location shouldn't do the shifting as it doesn't know the level
evenly-epic-mule
force-pushed
the
master
branch
from
35a7a36 to
5d0d138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g. spawn_point_id 0x "4xxxxxxxxxx" = 0b0100 would be shifted by 21
while spawn_point_id 0x "8xxxxxxxxxx" = 0b1000 would be shifted by 20
cellid_to_location shouldn't do the shifting as it doesn't know the level
additionally monocle (currently only used in the WIP branch) should be updated so that
spawnid_to_*will shift thespawnid << 20before callingcellid_to_*