-
Notifications
You must be signed in to change notification settings - Fork 4
CHA-620: Build Regular contract for Stake NODL tokens #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Douglasacost
wants to merge
11
commits into
main
Choose a base branch
from
CHA-620-stake-nodl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Includes functions to perform staking, claim rewards, withdraw in case of emergency and allow unstake. Events are added to track actions and validations are implemented to ensure proper staking conditions
…ble modifier is added to allow pausing and resuming staking operations, as well as new validations and related events. Custom errors are introduced to improve exception handling, and staking, reclaiming and unstaking functions are adjusted to respect the paused state
…ble, implementing specific roles for reward and emergency management. Pause-related events are removed and functions are adjusted to require roles instead of Ownable. A new test file is added to validate role functionality and contract operations
… functions to perform staking, claim rewards, withdraw in case of emergency and allow unstaking. Events are added to track actions and validations are implemented to ensure proper staking conditions. A new test file is included to validate the functionality of the staking contract
…on of a PRECISION constant, a new ‘unstaked’ state in the StakeInfo structure, and the private _calculateReward function to calculate rewards with high precision. Validations in the staking and claim functions are adjusted to correctly handle the new states, and related custom events and errors are updated. Additionally, ensures that the available reward balance is properly managed during staking and claiming operations
…aging rewards. Redundant comments are removed and validations are adjusted to ensure that available rewards are correctly verified before claiming. New reward management and emergency roles are introduced in testing, and test coverage is improved to verify the behavior of staking and claiming functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.