Rayon-style worker sleeping #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthTensor
force-pushed
the
advanced-sleeping
branch
2 times, most recently
from
94991df to
ae0a54e
Compare
NthTensor
force-pushed
the
advanced-sleeping
branch
from
ae0a54e to
5c90f8b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves us back to rayon-style latches, and allows us to wake workers that have gone to sleep waiting for a job to complete when there is new work available.
Forte had a version of this for a long time, but it had trouble with deadlocks and I eventually removed it. This new version rewrites the latch primitive from scratch, uses only simple atomic loads and stores (not CAS operations). I'm also much more confident that it's deadlock free.