fix: Avoid deadlock on downsizing of threadpool #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlattimore
force-pushed
the
push-knqpvwxsmxvn
branch
from
2b25f94 to
395842e
Compare
Author
|
This fixes two different deadlocks when downsizing. The first, was that the heartbeat thread wouldn't shut down because we tried to join the heartbeath thread while still holding the lock on the threadpool's state mutex, which the heartbeat thread also needed to lock before it could know to shut down. The second deadlock was that the worker threads weren't being woken up, so didn't know that they needed to shut down. There are existing tests that were hitting these deadlocks. e.g. Issue #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.