Config Loading - TOML file I/O and env overrides #39
+301
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using jj-spr 0.1.0
m-005
added a commit
that referenced
this pull request
Jan 21, 2026
Part 2 of the Foundation stage for objects-node daemon. ## Changes Implements configuration loading and validation: - ConfigError enum with proper error types (IO, Parse, Validation) - from_env() - Load configuration from environment variables only - load_or_create() - Load from TOML file or create with defaults - load() and save() - TOML file I/O with parent directory creation - validate() - Comprehensive validation: - API port in valid range (1024-65535) - Valid IP address for bind address - HTTPS-only relay URLs - RFC-002 compliant discovery topic format - Environment variable overrides with proper precedence ## Testing Uses temp-env for safe environment variable testing (no unsafe blocks): - Config file creation and loading - Environment variable override tests - Validation error cases (invalid port, IP, URL, topic) - Round-trip serialization ## Dependencies - Added temp-env for safe test environment manipulation - Added tempfile for temporary test directories Part of the Foundation stage (2/4). Builds on: #34. Next: State Types (#36). Pull Request: #39
m-005
deleted the
spr/m-005/config-loading-toml-file-io-and-env-overrides-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of the Foundation stage for objects-node daemon.
Changes
Implements configuration loading and validation:
Testing
Uses temp-env for safe environment variable testing (no unsafe blocks):
Dependencies
Part of the Foundation stage (2/4). Builds on: #34. Next: State Types (#36).