Config Loading - TOML file I/O and env overrides #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of #35 after rebasing to main.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Security improvements:
- Add proper URL parsing and validation for relay and registry URLs
- Validate URLs have valid HTTPS scheme and non-empty hosts
- Reject malformed URLs (empty host, invalid host, malformed syntax)
Observability improvements:
- Add structured tracing logs to all config methods
- Debug logs for normal operations (load, save, validate)
- Error logs for failures with full context
- Info logs for successful operations
- Warning logs for invalid environment variables (e.g., invalid port)
Documentation:
- Remove RFC-002 reference, describe actual validation format
- Discovery topic format: /objects/{network}/{version}/discovery
Tests:
- Add tests for malformed URL validation
- All 14 tests pass with new validation logic
m-005
force-pushed
the
spr/m-005/config-loading-toml-file-io-and-env-overrides
branch
from
702501f to
eecb1d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of the Foundation stage for objects-node daemon.
Changes
Implements configuration loading and validation:
ConfigErrorenum with proper error types (IO, Parse, Validation)from_env()- Load configuration from environment variables onlyload_or_create()- Load from TOML file or create with defaultsload()andsave()- TOML file I/O with parent directory creationvalidate()- Comprehensive validation:Testing
Uses
temp-envfor safe environment variable testing (no unsafe blocks):Dependencies
temp-envfor safe test environment manipulationtempfilefor temporary test directoriesPart of the Foundation stage (2/4). Builds on: #34. Next: State Types (#51).