[18.0][FIX] agreement_rebate: invoice_group is not in the context so is not taking care about it #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… taking care about it Before these changes, the value set in the “group invoices by” field was not taken into account when creating invoices. After these changes, invoices are created normally, grouped according to the selected option. In addition, an improvement has been added so that if an invoice is forced to a specific person, that value is used for grouping. When a value is selected for “Force invoice to”, the “group invoices by” option will be hidden.
CarlosRoca13
changed the title
pedrobaeza
approved these changes
Jan 14, 2026
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Seen with him in a video-call.
leemannd
approved these changes
Jan 15, 2026
|
cc @ivantodorovich as you're using it on some projects |
ivantodorovich
approved these changes
Jan 15, 2026
Member
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 2d28024. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes, the value set in the “group invoices by” field was not taken into account when creating invoices.
After these changes, invoices are created normally, grouped according to the selected option. In addition, an improvement has been added so that if an invoice is forced to a specific person, that value is used for grouping. When a value is selected for “Force invoice to”, the “group invoices by” option will be hidden.
cc @Tecnativa TT60305
ping @pedrobaeza @sergio-teruel