Skip to content

[16.0][MIG] pricelist_brand #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
david-s73 wants to merge 6 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] pricelist_brand #187

david-s73 wants to merge 6 commits into from

Conversation

@david-s73
Copy link

@david-s73 david-s73 commented Feb 5, 2024

Migration to 16, reference: odoo/odoo#79605

ferran-S73
ferran-S73 reviewed May 20, 2024
View reviewed changes
@david-s73 david-s73 force-pushed the 16.0-mig-pricelist_brand branch from cde5090 to 0a2e41b Compare May 20, 2024 11:44
@github-actions
Copy link

github-actions bot commented Sep 22, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@bosd
Copy link
Contributor

bosd commented Nov 3, 2024

@david-s73 Can you please fix pre-commit?

@david-s73 david-s73 force-pushed the 16.0-mig-pricelist_brand branch from 0a2e41b to ac51ba4 Compare November 4, 2024 07:13
sbejaoui
sbejaoui approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

bosd
bosd suggested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history is missing. Can you please follow the migration guide?

@max3903 max3903 added this to the 16.0 milestone Apr 9, 2025
Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
@david-s73 @hildickethan
feat(oca): OCA/brand#187
23fd56d
@david-s73 david-s73 force-pushed the 16.0-mig-pricelist_brand branch from ac51ba4 to 3b28eaa Compare November 4, 2025 09:49
@david-s73
Copy link
Author

david-s73 commented Nov 4, 2025

@bosd I can see that all previous commits have been carried over in the migration. Could you clarify what you mean?

Reyes4711-S73
Reyes4711-S73 approved these changes Nov 4, 2025
View reviewed changes
Copy link

@Reyes4711-S73 Reyes4711-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reyes4711-S73
Copy link

Reyes4711-S73 commented Nov 4, 2025

@sbejaoui Please, can you merge this PR?

@bosd
Copy link
Contributor

bosd commented Nov 4, 2025

@bosd I can see that all previous commits have been carried over in the migration. Could you clarify what you mean?

i was expecting more of a commit history. But it seems that there is none for this module. so it is ok now.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 4, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Reyes4711-S73
Copy link

Reyes4711-S73 commented Nov 12, 2025

@OCA/brand-maintainers Please, can you review/merge this PR?

@andreampiovesana
Copy link
Contributor

andreampiovesana commented Dec 1, 2025

merge?

@andreampiovesana
Copy link
Contributor

andreampiovesana commented Dec 13, 2025

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbejaoui sbejaoui sbejaoui approved these changes

+4 more reviewers

@bosd bosd bosd approved these changes

@Reyes4711-S73 Reyes4711-S73 Reyes4711-S73 approved these changes

@ferran-S73 ferran-S73 ferran-S73 approved these changes

@Alexgars73 Alexgars73 Alexgars73 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved migration needs review ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.