[19.0][MIG] account_brand: Migration to 19.0 #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was on OCA/partner-contact, switch to OCA/brand
[ADD] - add sbejaoui as maintainer [IMP] - move brand config section outside multi_company section [FIX] - add brand_use_level to fields_view_get fields
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: brand-17.0/brand-17.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-17-0/brand-17-0-account_brand/
Currently translated at 100.0% (21 of 21 strings) Translation: brand-17.0/brand-17.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-17-0/brand-17-0-account_brand/it/
Currently translated at 95.2% (20 of 21 strings) Translation: brand-18.0/brand-18.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-account_brand/nl/
…tomer Credit Notes
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: brand-18.0/brand-18.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-account_brand/
Currently translated at 100.0% (22 of 22 strings) Translation: brand-18.0/brand-18.0-account_brand Translate-URL: https://translation.odoo-community.org/projects/brand-18-0/brand-18-0-account_brand/it/
|
/ocabot migration account_brand |
rousseldenis
reviewed
Oct 6, 2025
| string="Account", | ||
| required=True, | ||
| domain="[('account_type', 'in', ('liability_payable', 'asset_receivable'))]", | ||
| domain="[('account_type', '=', account_type)]", |
There was a problem hiding this comment.
Is domain evaluated dynamically? I think this is evaluated statically, so, if you change account_type field, the list is not adapted, correct ?
Author
There was a problem hiding this comment.
Yes, the domain works dynamically.
Basically, in v15, it was dynamic based on the onchange event: https://github.com/OCA/brand/blob/15.0/account_brand/models/res_partner_account_brand.py#L57
When migrated to v16, it was not considered because the domain return from onchange is not supported from v16 onwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency PR for module
brand: #270