Skip to content

Conversation

@pcastelovigo
Copy link

using oca-port

@pcastelovigo pcastelovigo mentioned this pull request Nov 22, 2025
8 tasks
Copy link
Contributor

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see change commit that was applied in v18.
I think this is relevant in v16 too, as Odoo changed analytic accounts to analytic distributions.
4b05ed0

@pcastelovigo
Copy link
Author

Please see change commit that was applied in v18. I think this is relevant in v16 too, as Odoo changed analytic accounts to analytic distributions. 4b05ed0

yes, it seems it need to be adapted to distributions,
i'll try to do this week, thanks

@pcastelovigo pcastelovigo marked this pull request as draft November 24, 2025 08:52
@pcastelovigo pcastelovigo force-pushed the 16.0-mig-analytic_brand branch 3 times, most recently from cbdd3c3 to 9cb900a Compare November 28, 2025 17:52
@pcastelovigo pcastelovigo marked this pull request as ready for review November 28, 2025 17:54
@pcastelovigo
Copy link
Author

@marielejeune i think its ready

Copy link
Contributor

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow migration guidelines: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

All the commit history is squashed, and the migration commit doesn't contain anything.

@pcastelovigo pcastelovigo force-pushed the 16.0-mig-analytic_brand branch from 9cb900a to faa39eb Compare December 2, 2025 12:45
@pcastelovigo pcastelovigo reopened this Dec 2, 2025
@pcastelovigo
Copy link
Author

Please follow migration guidelines: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

All the commit history is squashed, and the migration commit doesn't contain anything.

misunderstood the guidelines, thank you for your patience

Copy link
Contributor

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note that I'm currently facing some issues/difficulties using this module in v18.
The reason is that the analytic distribution is defined on the brand, while other composants use the analytic distribution models.

I think I will modify the module to add the brand dimension inside analytic distribution models too. I think this is something that could be useful for v16 too.

@pcastelovigo
Copy link
Author

LGTM.

Note that I'm currently facing some issues/difficulties using this module in v18. The reason is that the analytic distribution is defined on the brand, while other composants use the analytic distribution models.

I think I will modify the module to add the brand dimension inside analytic distribution models too. I think this is something that could be useful for v16 too.

I expected it to add automatically the analytic tag to account.moves using that brand but it does not work that way, it was also in the precedent versions.
I had code to add them with used with account_brand.. I'll check your work in the future

@marielejeune
Copy link
Contributor

marielejeune commented Dec 19, 2025

Hi @pcastelovigo,
Please check at my refactoring to use account analytic distribution models, ready here: #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants