-
-
Notifications
You must be signed in to change notification settings - Fork 194
[16.0][MIG] analytic brand #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
marielejeune
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see change commit that was applied in v18.
I think this is relevant in v16 too, as Odoo changed analytic accounts to analytic distributions.
4b05ed0
yes, it seems it need to be adapted to distributions, |
cbdd3c3 to
9cb900a
Compare
|
@marielejeune i think its ready |
marielejeune
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow migration guidelines: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0
All the commit history is squashed, and the migration commit doesn't contain anything.
9cb900a to
faa39eb
Compare
[UPD] README.rst
[UPD] README.rst [FIX] Fixed travis.
[UPD] Update analytic_brand.pot
Currently translated at 100.0% (2 of 2 strings) Translation: brand-15.0/brand-15.0-analytic_brand Translate-URL: https://translation.odoo-community.org/projects/brand-15-0/brand-15-0-analytic_brand/es/
misunderstood the guidelines, thank you for your patience |
marielejeune
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note that I'm currently facing some issues/difficulties using this module in v18.
The reason is that the analytic distribution is defined on the brand, while other composants use the analytic distribution models.
I think I will modify the module to add the brand dimension inside analytic distribution models too. I think this is something that could be useful for v16 too.
I expected it to add automatically the analytic tag to account.moves using that brand but it does not work that way, it was also in the precedent versions. |
|
Hi @pcastelovigo, |
using oca-port